Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote async with deferred launch policy #1934

Merged
merged 1 commit into from Jan 10, 2016
Merged

Fix remote async with deferred launch policy #1934

merged 1 commit into from Jan 10, 2016

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Dec 28, 2015

  • refactored lcos::promise and lcos::packaged_action
  • added test

This fixes #1523

- refactored lcos::promise and lcos::packaged_action
- added test
}

lcos::packaged_action<Action, Result> p;
p.apply(std::move(addr), target_is_managed ? id1 : id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the launch policy is missing here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote operations don't support launch policies, they never had.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hpx/lcos/detail/async_implementations.hpp:

             target_is_managed = true;
         }
  •        else
    
  •        {
    
  •            p.apply(launch::sync, id, std::forward<Ts>(vs)...);
    
  •        }
    
  •        lcos::packaged_action<Action, Result> p;
    
  •        p.apply(std::move(addr), target_is_managed ? id1 : id,
    

Remote operations don't support launch policies, they never had.

If I'm not mistaken, that's for the local case, no? If launch policies are
not supported, why care for deferred?
It sounds a bit contradicting...

This is the remote (action based case). What I meant was that (remote) hpx::apply has never supported launch policies (hpx::async does, however). It would be a separate ticket if we needed/wanted to have those for hpx::apply.

hkaiser added a commit that referenced this pull request Jan 10, 2016
Fix remote async with deferred launch policy
@hkaiser hkaiser merged commit 3206b35 into master Jan 10, 2016
@hkaiser hkaiser deleted the fixing_1523_2 branch January 10, 2016 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote async with deferred launch policy never executes
2 participants