Fixing yet another lock that is being held during suspension #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| util::unlock_guard<boost::unique_lock<mutex_type> > unlock(l); | ||
| base_counter_id = get_counter(base_counter_name_, ec); | ||
| } | ||
| // After reaxquiring the lock, we need to check again if base_counter_id_ |
There was a problem hiding this comment.
Nitpick: there is a typo in the comment, otherwise this LGTM.
sithhell
force-pushed
the
fix_held_lock
branch
from
144fb1c
to
bf00960
Compare
hkaiser
added a commit
that referenced
this pull request
Jan 10, 2016
Fixing yet another lock that is being held during suspension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.