Fixing continuation recursions to not depend on fixed amount of recursions #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions - Disabling the continuation recursion counter on windows because it is not needed there (stack grows dynamically) - Adding function to retrieve the current value of the stack pointers on supported platforms (x86, x86_64, arm and powerpc) - When running the completion handlers, check for available stack base to decide wether to recurse asynchronously or not - Fallback to continuation recursion count for platforms where we can't retrieve the stack pointer
|
LGTM, thanks! |
sithhell
force-pushed
the
fixing_continuation_recursion
branch
from
64f6c3f
to
a57a993
Compare
…sions - Disabling the continuation recursion counter on windows because it is not needed there (stack grows dynamically) - Adding function to retrieve the current value of the stack pointers on supported platforms (x86, x86_64, arm and powerpc) - When running the completion handlers, check for available stack base to decide wether to recurse asynchronously or not - Fallback to continuation recursion count for platforms where we can't retrieve the stack pointer
sithhell
added a commit
that referenced
this pull request
Jan 28, 2016
…sion Fixing continuation recursions to not depend on fixed amount of recursions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed there (stack grows dynamically)
supported platforms (x86, x86_64, arm and powerpc)
to decide wether to recurse asynchronously or not
the stack pointer
This patch fixes a lot of problems with stack overflows in general and leads to less asynchronous completion handler executions in some cases.