Replacing uintptr_t (which is not defined everywhere) with std::size_t #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,8 +233,7 @@ namespace hpx { namespace util { namespace coroutines | |||
| std::ptrdiff_t get_available_stack_space() | |||
| { | |||
| #if defined(HPX_HAVE_THREADS_GET_STACK_POINTER) | |||
| return | |||
| reinterpret_cast<uintptr_type>(stack_pointer_) - get_stack_ptr(); | |||
| return get_stack_ptr() - reinterpret_cast<std::size_t>(stack_pointer_); | |||
There was a problem hiding this comment.
you switch the minuends. It should read:
reinterpret_cast<std::size_t>(stack_pointer_) - get_stack_ptr();
There was a problem hiding this comment.
I made it consistent with the other implementations. Should this one be different?
There was a problem hiding this comment.
Yes, this was on purpose since the stack_pointer_ here points to the top of stack already, while the other ones point to the bottom.
sithhell
added a commit
that referenced
this pull request
Feb 10, 2016
Replacing uintptr_t (which is not defined everywhere) with std::size_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the leftovers of #1969.