Making parcel coalescing test actually test something #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Apr 28, 2016
hkaiser
commented
- making sure -DHPX_PARCEL_COALESCING_MODULE_EXPORTS is not propagated to all tests
- flyby: added HPX_DECLARE_PLAIN_ACTION()
- flyby: made client<>::client(future<id_type>&&) non-explicit
- making sure -DHPX_PARCEL_COALESCING_MODULE_EXPORTS is not propagated to all tests - flyby: added HPX_DECLARE_PLAIN_ACTION() - flyby: made client<>::client(future<id_type>&&) non-explicit
|
@justwagle Please verify whether this branch fixes the issues you're seeing on Windows when trying to use parcel coalescing |
- this is a breaking change
hkaiser
force-pushed
the
fixing_parcel_coalescing
branch
from
1f01a5a
to
e9e8b9f
Compare
|
@hkaiser This fixes the issue of action not being correctly registered for parcel coalescing. The counters are now showing values other than 0 for the toy application I am testing with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.