Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding fedora docs" #2138

Closed
wants to merge 1 commit into from
Closed

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented May 2, 2016

This PR should be reverted. I see a couple of problems with this patch:
In general, I would like to avoid to have each linux distribution documented separately, this creates a maintenance nightmare in the end, I think a more appropriate place for information like this would be the Wiki. We already state the prerequisites in the docs. Installing those from the package manager should not require additional documentation from our end.
More specifically with this patch, the packages that get installed doesn't match the cmake configuration line, that is, there are some superfluous packages (the documentation toolchain, libsodium, hdf5 and openmpi).

@sithhell
Copy link
Member Author

sithhell commented May 2, 2016

I would rather suggest to merge the information regarding what packages need to get installed on what distribution for which feature in the prerequisites page.

@hkaiser
Copy link
Member

hkaiser commented May 2, 2016

I would rather suggest to merge the information regarding what packages need to get installed on what distribution for which feature in the prerequisites page.

I'd be fine with that. Will you add this to this PR?

@sithhell
Copy link
Member Author

sithhell commented May 2, 2016

On 05/02/2016 02:03 PM, Hartmut Kaiser wrote:

I would rather suggest to merge the information regarding what
packages need to get installed on what distribution for which
feature in the prerequisites page.

I'd be fine with that. Will you add this to this PR?

I can do that when I find the time. But it's on a very low priority.

@hkaiser
Copy link
Member

hkaiser commented May 2, 2016

I can do that when I find the time. But it's on a very low priority.

Why is removing the fedora docs very high-priority, then?

@sithhell
Copy link
Member Author

sithhell commented May 2, 2016

well, I want to have my complaints documented.

@hkaiser
Copy link
Member

hkaiser commented May 2, 2016

well, I want to have my complaints documented.

That would have been better documented as a ticket, then. As stated before, long living PRs are a maintenance nightmare, I'd rather close any PRs as quickly as possible.

@sithhell
Copy link
Member Author

sithhell commented May 2, 2016

Am 02.05.2016 2:29 nachm. schrieb "Hartmut Kaiser" <notifications@github.com

:

well, I want to have my complaints documented.

That would have been better documented as a ticket, then. As stated
before, long living PRs are a maintenance nightmare, I'd rather close any
PRs as quickly as possible.

So we are discussing the process now? Are there any technical issues with
what I proposed?
Regarding the process, I don't think that this particular set of changes
creates any conflicts. As did the original PR, but whatever. Will turn it
into an issue.

@sithhell
Copy link
Member Author

sithhell commented May 2, 2016

Moving this to #2140

@sithhell sithhell closed this May 2, 2016
@hkaiser hkaiser deleted the revert-1839-adding_fedora_docs branch May 2, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants