Support Boost.Thread v4 #2192
Merged
Support Boost.Thread v4 #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace boost::condition with boost::condition_variable - Replace typename Mutex::scoped_lock with unique_lock<Mutex>
|
Do we have to explicitly enable V4 of the threads library? Is that the default? |
|
The default is v2 for backwards compatibility, v4 is recommended as it aligns more closely with the standard. It's up to the user to pick the version they want. We don't have to (and should not) mess with that, just make sure that we can work with |
|
Ok, thanks. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::conditionwithboost::condition_variabletypename Mutex::scoped_lockwithunique_lock<Mutex>