Adding iterator_facade and iterator_adaptor #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding tests for iterator_facade (from Boost) - adding tests for zip_iterator and transform_iterator (from Boost) - fixing problems in zip_iterator and transform_iterator to make tests pass - consolidate all iterator tests in separate directory
# Conflicts: # hpx/util/zip_iterator.hpp
- Mark up remaining functions with HPX_HOST_DEVICE - adding iterator_adaptor test (adapted from Boost) - consolidated iterator test facilities - adding missing operators to iterator_facade
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
hpx::util::iterator_facadeandhpx::util::iterator_adaptor. The goal is to replace the corresponding Boost facilities over time.This change is necessary as various iterators built on top of those are needed for the HPX.Compute implementation which requires to mark up the functions as
HPX_HOST_DEVICE.