Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::chrono with std::chrono in interfaces #2275

Merged
merged 9 commits into from Aug 6, 2016
Merged

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Jul 31, 2016

No description provided.

@K-ballo
Copy link
Member Author

K-ballo commented Jul 31, 2016

This is a breaking change as it disables dual support for boost::chrono. For the short term, the old behavior can be brought back via HPX_WITH_BOOST_CHRONO_COMPATIBILITY.

@hkaiser
Copy link
Member

hkaiser commented Jul 31, 2016

Could this be (conditionally) removed now as well: https://github.com/STEllAR-GROUP/hpx/blob/master/cmake/HPX_SetupBoost.cmake#L26?

@K-ballo
Copy link
Member Author

K-ballo commented Jul 31, 2016

Could this be (conditionally) removed now as well: https://github.com/STEllAR-GROUP/hpx/blob/master/cmake/HPX_SetupBoost.cmake#L26?

I believe not because Boost.Thread still links against it, but I'm not sure. Will give it a try...

@hkaiser
Copy link
Member

hkaiser commented Aug 2, 2016

@K-ballo could you rebase this branch, please?

@K-ballo K-ballo force-pushed the chrono branch 3 times, most recently from f553020 to 150eebe Compare August 3, 2016 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants