Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for hpx.compute and hpx::lcos::channel #2347

Merged
merged 2 commits into from Sep 28, 2016
Merged

Bug fixes for hpx.compute and hpx::lcos::channel #2347

merged 2 commits into from Sep 28, 2016

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented Sep 27, 2016

From the commit messages:

Fixing locking problems in hpx::lcos::channel

This patch fixes problem in the channel implementation that led to locks being
held during suspension.

Fixing hpx::compute::traits::allocator_traits and vector

 - hpx::compute::traits::allocator_traits didn't work with std::allocator<T>
  because it was using the pointer type instead of value_type for the initial
  value
 - hpx::compute::vector move operations lead to data being double freed because
   the move ctor didn't set the rhs data pointer to nullptr

Thomas Heller added 2 commits September 27, 2016 16:17
 - hpx::compute::traits::allocator_traits didn't work with std::allocator<T>
  because it was using the pointer type instead of value_type for the initial
  value
 - hpx::compute::vector move operations lead to data being double freed because
   the move ctor didn't set the rhs data pointer to nullptr
This patch fixes problem in the channel implementation that led to locks being
held during suspension.
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser added this to the 1.0.0 milestone Sep 27, 2016
@hkaiser hkaiser merged commit 3f99ece into master Sep 28, 2016
@hkaiser hkaiser deleted the bug_fixes branch September 28, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants