Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute warning for gcc #2429

Merged
merged 1 commit into from Dec 20, 2016
Merged

Fix attribute warning for gcc #2429

merged 1 commit into from Dec 20, 2016

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Dec 19, 2016

  • flyby: remove IB-Verbs and IPC from HPXConfig.cmake.in

@hkaiser
Fix attribute warning for gcc
4d42366 
- flyby: remove IB-Verbs and IPC from HPXConfig.cmake.in
@hkaiser hkaiser added this to the 1.0.0 milestone Dec 19, 2016
@hkaiser hkaiser mentioned this pull request Dec 19, 2016
Closed
@hkaiser
Copy link
Member Author

hkaiser commented Dec 19, 2016

This addresses a comment we received for #2109.

@sithhell
Copy link
Member

This only fixes warnings for thread there are still a lot of others lingering around.

@hkaiser
Copy link
Member Author

hkaiser commented Dec 20, 2016

@sithhell Fixing it for thread was the purpose of this PR. What's wrong with it?

@sithhell
Copy link
Member

sithhell commented Dec 20, 2016 via email

@hkaiser
Copy link
Member Author

hkaiser commented Dec 20, 2016

@sithhell Give me a list of warnings and I can try doing this. My compiler does not report those.

@sithhell
Copy link
Member

@hkaiser sorry, I misread the issue. I was seeing several warnings like these when using ICC, didn't realize the linked issue was closed some time ago. Indeed, the new comment only mentions threads.

@hkaiser
Copy link
Member Author

hkaiser commented Dec 20, 2016

@sithhell Could you review this PR, please?

@hkaiser hkaiser mentioned this pull request Dec 20, 2016
Merged
sithhell
sithhell approved these changes Dec 20, 2016
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. #2432 solves the same problem in a different way (wrt hpx::thread). I guess this solution is cleaner. I suggest to merge this PR first and adapt #2432 afterwards.

@hkaiser hkaiser merged commit 8d562f4 into master Dec 20, 2016
@hkaiser hkaiser deleted the fixing_2109 branch December 20, 2016 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: core compiler: gcc type: compatibility issue
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell