Mismatch between #if/#endif and namespace scope brackets in this_thread_executers.hpp

[brandon-kohn]

https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/threads/executors/this_thread_executors.hpp

Note that the namespaces are declared inside a #if/#endif construct but the closing brackets are outside any such preprocessor scope.

[hkaiser]

Thanks! Would you mind preparing a patch for this?

[brandon-kohn]

Sure :), I'll push the namespaces into #if/#endif scope.

[brandon-kohn]

Here's a (hastily put together and untested) patch.
issue_2442.zip

Thanks!

[hkaiser]

@brandon-kohn Thanks for this. Could you turn that into a 'real' pull request here on github, please? Also, I think it would be sufficient to move the #endif here to the end of the file.

[brandon-kohn]

Done and done, hopefully I got the pull request correct. This is my first time collaborating through github in this way; so please bear with me.

[hkaiser]

Yes, all is well. For the requested changes, just keep pushing commits to the same branch it will show up on the pull request. Thanks!

[hkaiser]

This has been fixed by merging #2443