Refining support for ITTNotify #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- making itt task API more efficient (by caching the itt string for the task name) - flyby: explicitly defining all necessary base_lco_with_value types
sithhell
requested changes
Feb 1, 2017
hpx/runtime/actions/basic_action.hpp
Outdated
| template <> HPX_ALWAYS_EXPORT \ | ||
| char const* get_action_name<action>(); \ | ||
| template <> HPX_ALWAYS_EXPORT \ | ||
| util::itt::string_handle const& get_action_name_itt<action>(); \ |
There was a problem hiding this comment.
Can we just factor the get_action_name_itt declaration out? this would avoid the duplication of the code in those macros.
hpx/runtime/actions/basic_action.hpp
Outdated
| return BOOST_PP_STRINGIZE(actionname); \ | ||
| } \ | ||
| template<> HPX_ALWAYS_EXPORT \ | ||
| util::itt::string_handle const& get_action_name_itt<action>() \ |
| HPX_EXPORT void itt_task_end(___itt_domain const*); | ||
|
|
||
| HPX_EXPORT ___itt_domain* itt_domain_create(char const*); | ||
| HPX_EXPORT ___itt_string_handle* itt_task_handle_create(char const*); | ||
| HPX_EXPORT ___itt_string_handle* itt_string_handle_create(char const*); |
There was a problem hiding this comment.
do we have some minimum itt version we support?
There was a problem hiding this comment.
None we could check at compile time. The Intel itt_notify.h has the same version number in it for years, even while the API itself has changed significantly.
There was a problem hiding this comment.
Should we document the supported version somewhere?
There was a problem hiding this comment.
I don't even know what version is the correct one... But using the newest VTune is probably a safe bet ;)
|
@sithhell Your review comments have been addressed. |
sithhell
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reduces the overheads introduced when using ITTNotify to tie in VTune (or other tools).