Added priority-queue lifo scheduler #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Feb 5, 2017
hkaiser
commented
- flyby: removed unneeded #includes
- flyby: removed unneeded type definitions
- flyby: removed unneeded #includes - flyby: removed unneeded type definitions
hkaiser
force-pushed
the
lifo_scheduler
branch
from
be8c54b
to
57f3d8d
Compare
sithhell
reviewed
Feb 6, 2017
|
|
||
| // define the default scheduler to use | ||
| typedef fifo_priority_queue_scheduler queue_scheduler; | ||
|
|
There was a problem hiding this comment.
Why are those not needed anymore?
There was a problem hiding this comment.
Those have never been used. I removed them to avoid instantiating the scheduler types in each translation unit which pulls this #include file.
There was a problem hiding this comment.
Can't all the other schedulers be removed from there as well then?
There was a problem hiding this comment.
The others are not typedef'ed, but forward declared only.
There was a problem hiding this comment.
Ok, I was just thinking since they aren't used from those forward declarations anyway, just to avoid unneeded code in the headers.
There was a problem hiding this comment.
Ok, fair point. I'll try to do that, let's see how it goes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.