Fixing parcel scheduling #2518
Fixing parcel scheduling #2518
Conversation
|
@sithhell Could you please explain a bit what this patch does? |
|
In short: whenever we have more than 1 parcel to decode, and at least two of those parcels contain a direct action, every direct action except the last is scheduled on a new HPX thread. This is to avoid deadlock situations if this direct action is being put into suspended mode. |
|
Do I have to like that what seemed to be a good idea (i.e. execute direct actions directly) starts influencing more places in the code than we would have even remotely expected? I still think that all of this has a non-healthy ring to it. We have to introduce more and more tricky workarounds into various, unrelated places. I don't have a better suggestion however at this point. |
|
While I agree that the change in general had a big impact on what needed to be changed, I still think it is overall good, I wouldn't call the places which needed change unrelated though, they were all dealing with scheduling threads/actions. If at all, I think the concept of direct actions is incomplete, while of course offering a great optimization possibility. I wouldn't want to loose that, I put some effort into commenting the pieces of code such that they hopefully don't appear to be that tricky after all. |
|
Thomas, I wouldn't call the changes to the barrier code being related to scheduling threads/actions etc. But as said, I don't have a better suggestion at this point. So please go ahead and merge this. |
|
Please note the inspect report, though: https://6061-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.oGIwqiR/hpx_inspect_report.html |
sithhell
force-pushed
the
fixing_2516
branch
from
e676c95
to
10c04dc
Compare
Due to the recent changes in executing background_work in an HPX thread, parcel decoding could create a deadlock when a direct actions suspends and there are more parcels to decode and schedule. This patch remedies this situation. This fixes #2516. Flyby: Only notify the big boot barrier CV once
sithhell
force-pushed
the
fixing_2516
branch
from
10c04dc
to
153bf4f
Compare
Due to the recent changes in executing background_work in an HPX thread,
parcel decoding could create a deadlock when a direct actions suspends
and there are more parcels to decode and schedule. This patch remedies
this situation.
This fixes #2516.