Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing scan partitioner #2556

Merged
merged 1 commit into from Mar 27, 2017
Merged

Fixing scan partitioner #2556

merged 1 commit into from Mar 27, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Mar 22, 2017

This is based from a solution as proposed by @sithhell. It fixes the test failures around scan_by_key we're currently seeing.

Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. It would be really interesting to get the cause of the failure though...

@hkaiser hkaiser merged commit 413db97 into master Mar 27, 2017
@hkaiser hkaiser deleted the fixing_scan_partitioner branch March 27, 2017 17:19
@taeguk
Copy link
Member

taeguk commented Aug 13, 2017

I can't understand what points of this PR fix the test failures.
Could you explain to me?
It seems that this PR just do only changing order of calling f2 and f3. I want to know what it means. As I think, the order doesn't be meaningful.

finalitems.push_back(dataflow(hpx::launch::sync,
f3, it, size, prev, curr));
workitems.push_back(dataflow(hpx::launch::sync,
f2, prev, curr));

#2325 (just for github link connection.)

@hkaiser
Copy link
Member Author

hkaiser commented Aug 13, 2017

Yes, you're right. The order should not matter. However, the scan_by_key test breaks if you change the sequence of those calls. We don't know ourselves what's actually happening.

sithhell pushed a commit that referenced this pull request Jan 30, 2018
As time went by, we can re-enable the usage of executors again. Some changes
in our code base seem to have led to this not segfaulting anymore.
@sithhell sithhell mentioned this pull request Jan 30, 2018
sithhell pushed a commit that referenced this pull request Jan 31, 2018
As time went by, we can re-enable the usage of executors again. Some changes
in our code base seem to have led to this not segfaulting anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants