First attempt to introduce spmd_block in hpx #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 10, 2017 15:54
|
Fix this compilation error: https://circleci.com/gh/STEllAR-GROUP/hpx/6485 |
|
Now inspect is not happy with this anymore: https://6489-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.ksvyahZ/hpx_inspect_report.html Also, I don't think replacing |
atrantan
force-pushed
the
spmd_block_local_release
branch
from
3bfbc34
to
eeecfa8
Compare
added 2 commits
April 21, 2017 11:10
atrantan
force-pushed
the
spmd_block_local_release
branch
from
28ec500
to
2f10ac3
Compare
atrantan
force-pushed
the
spmd_block_local_release
branch
from
2f10ac3
to
249a01d
Compare
hkaiser
reviewed
Apr 22, 2017
tests/unit/parallel/spmd_block.cpp
Outdated
| hpx::wait_all(join); | ||
|
|
||
| delete(c1); | ||
| delete(c2); |
There was a problem hiding this comment.
Wouldn't it be much easier if you wrote:
boost::atomic<std::size_t> c1(0);
hpx::parallel::v2::define_spmd_block(
num_images, std::move(bulk_test), &c1);
IIRC, there is no need to dynamically allocate the atomic variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to introduce code related to spmd_block that was presented here http://stellar.cct.lsu.edu/pubs/extending_cpp_with_coarray_semantics_2016.pdf
A major difference in comparaison to what was presented in that paper is that an image is no longer considered as a computation located in an explicit locality. It is now a simple sequential computation able to cooperate with other ones.