New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting generic context for boost >= 1.61 #2606
Conversation
@AntonBikineev: I had some work done for this here: https://github.com/STEllAR-GROUP/hpx/tree/fixing_2471, but it crashed for me if a hpx-thread was moved to a different core. Have you seen similar problems? |
@hkaiser I don't know, tests seemed to work fine on my laptop :) |
@hkaiser I hadn't seen your patch. I think this can be closed then |
@AntonBikineev if your PR works we should go ahead with it. The branch I referred to does not properly work. |
422e823
to
e7b0d70
Compare
@hkaiser Do hpx tests cover the situation with moving hpx-threads? |
@AntonBikineev we don't have explicit tests, but for me the problem showed up by just running Also, inspect does not like your PR: https://6607-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.qtJDgAu/hpx_inspect_report.html |
e7b0d70
to
1b1eaab
Compare
@hkaiser I haven't observed this problem neither on mac nor linux. Maybe it was fixed by some another PR... |
@hkaiser BTW, can I setup CI to use a specific boost version? |
Not easily... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
I might have misunderstood. Did you mean on circleci? or on our buildbot? |
hm, I don't know, on any of those :) |
@AntonBikineev you might want to get in contact with @Hapoo (Alireza), he can help setting something up on buildbot. |
No description provided.