Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting generic context for boost >= 1.61 #2606

Merged
merged 1 commit into from May 8, 2017
Merged

Conversation

AntonBikineev
Copy link
Contributor

No description provided.

@hkaiser
Copy link
Member

hkaiser commented May 4, 2017

@AntonBikineev: I had some work done for this here: https://github.com/STEllAR-GROUP/hpx/tree/fixing_2471, but it crashed for me if a hpx-thread was moved to a different core. Have you seen similar problems?

@AntonBikineev
Copy link
Contributor Author

@hkaiser I don't know, tests seemed to work fine on my laptop :)

@AntonBikineev
Copy link
Contributor Author

@hkaiser I hadn't seen your patch. I think this can be closed then

@hkaiser
Copy link
Member

hkaiser commented May 4, 2017

@AntonBikineev if your PR works we should go ahead with it. The branch I referred to does not properly work.

@AntonBikineev
Copy link
Contributor Author

@hkaiser Do hpx tests cover the situation with moving hpx-threads?

@hkaiser
Copy link
Member

hkaiser commented May 5, 2017

@AntonBikineev we don't have explicit tests, but for me the problem showed up by just running hello_world with --hpx::threads=N, where N > 1.

Also, inspect does not like your PR: https://6607-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.qtJDgAu/hpx_inspect_report.html

@AntonBikineev
Copy link
Contributor Author

@hkaiser I haven't observed this problem neither on mac nor linux. Maybe it was fixed by some another PR...

@AntonBikineev
Copy link
Contributor Author

@hkaiser BTW, can I setup CI to use a specific boost version?

@hkaiser
Copy link
Member

hkaiser commented May 5, 2017

BTW, can I setup CI to use a specific boost version

Not easily...

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@hkaiser
Copy link
Member

hkaiser commented May 5, 2017

BTW, can I setup CI to use a specific boost version

Not easily...

I might have misunderstood. Did you mean on circleci? or on our buildbot?

@AntonBikineev
Copy link
Contributor Author

hm, I don't know, on any of those :)

@hkaiser
Copy link
Member

hkaiser commented May 5, 2017

@AntonBikineev you might want to get in contact with @Hapoo (Alireza), he can help setting something up on buildbot.

@hkaiser hkaiser merged commit b298abb into master May 8, 2017
@hkaiser hkaiser deleted the support_boost_gt_160 branch May 8, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants