Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hpx::local_new #2617

Merged
merged 1 commit into from May 12, 2017
Merged

Adding hpx::local_new #2617

merged 1 commit into from May 12, 2017

Conversation

Smasherr
Copy link
Contributor

@Smasherr Smasherr commented May 9, 2017

  • this is equivalent to hpx::new_<>(find_here(), ...), except that it allows
    for non-copyable and non-movable argument types and guarantees purely local
    operation
  • also adding test
  • flyby: #ifdef extended friend declarations in simple_component_base
  • flyby: fix destruction of components if id couldn't be assigned
  • flyby: fixing error messages generated if id couldn't be assigned

- this is equivalent to `hpx::new_<>(find_here(), ...)`, except that it allows
  for non-copyable and non-movable argument types and guarantees purely local
  operation
- also adding test
- flyby: #ifdef extended friend declarations in simple_component_base
- flyby: fix destruction of components if id couldn't be assigned
- flyby: fixing error messages generated if id couldn't be assigned
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hkaiser hkaiser changed the title Adding 'hpx::local_new Adding hpx::local_new May 12, 2017
@hkaiser hkaiser merged commit efae43e into master May 12, 2017
@hkaiser hkaiser deleted the local_new branch May 12, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants