Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unordered_map out of parcelport into hpx/concurrent #2629

Closed
wants to merge 1 commit into from

Conversation

biddisco
Copy link
Contributor

Also move readers_writers_mutex into hpx/lcos/local

These classes are now stable enough to be used outside of just
the parcelport code

Also move readers_writers_mutex into hpx/lcos/local

These classes are now stable enough to be used outside of just
the parcelport code
@hkaiser
Copy link
Member

hkaiser commented May 15, 2017

Do you have a test to go with this?

@biddisco
Copy link
Contributor Author

An excellent question. The answer is no.

If I create a test - is there a canonical way to test that there are no race conditions?
I can iterate of millions of items and do set/get operations and check none are incorrect but ....

@hkaiser
Copy link
Member

hkaiser commented May 15, 2017

There is no way to guarantee the absence of races. But you could run millions of tests, each time with different items and different number of items and over time we will gain confidence that the code is race free. At least that's what we do to 'ensure' there are no races in the rest of HPX.

@sithhell
Copy link
Member

The reader_writer_mutex needs to be implemented platform independent, it currently relies on gcc intrinsics.

@biddisco biddisco closed this Jul 11, 2017
@biddisco biddisco deleted the concurrent_map branch July 11, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants