Unify access_data trait for use in both, serialization and de-serialization #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
May 29, 2017
hkaiser
commented
- adding daft example demonstrating the use of this trait for writing/reading to a file
…zation - adding daft example demonstrating the use of this trait for writing/reading to a file
hkaiser
force-pushed
the
serialization_access_data
branch
from
f15975d
to
6335a35
Compare
aserio
reviewed
Jun 7, 2017
| { | ||
| static std::size_t size(file_wrapper const& cont) | ||
| { | ||
| return cont.size(); |
There was a problem hiding this comment.
Could this function return cont.size_data() if "size_data()" was defined in file_wrapper?
There was a problem hiding this comment.
Sure, if the name of the corresponding function exposed by the file_wrapper type is renamed as well... But why?
There was a problem hiding this comment.
In this context I do not need the size of my entire container but just of a portion of it aka the "data" portion. I would prefer to be able to have two functions .size() and .size_data() that my object exposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.