Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cuda Clang builds pass #2688

Merged
merged 2 commits into from Jun 19, 2017
Merged

Make Cuda Clang builds pass #2688

merged 2 commits into from Jun 19, 2017

Conversation

atrantan
Copy link

@atrantan atrantan commented Jun 8, 2017

This patch tries to solve some issue when building hpx with enabled Cuda Clang.

@atrantan atrantan changed the title Add missing include to make Cuda Clang builds pass Make Cuda Clang builds pass Jun 8, 2017
@hkaiser hkaiser added this to the 1.1.0 milestone Jun 8, 2017
{
sync_execute(std::forward<F>(f), std::forward<Ts>(ts)...);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's rather change that spot to use sync_execute(). I must have missed changing that while re-implementing the executors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 66c5d58

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit e853e98 into STEllAR-GROUP:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants