Config support for fallthrough attribute #2717
Conversation
hpx/config/attributes.hpp
Outdated
| #include <hpx/config/defines.hpp> | ||
|
|
||
| #if defined(HPX_HAVE_CXX17_FALLTHROUGH_ATTRIBUTE) | ||
| # define HPX_FALLTHROUGH [[fallthrough]]; |
There was a problem hiding this comment.
I'd suggest to remove the semicolon from the macro definition. Let's leave this to the user. This is not a big issue, some compilers warn about duplicate semicolons, though...
There was a problem hiding this comment.
Duplicate semicolon because the user may follow the macro with a semicolon?
HPX_FALLTHROUGH;
There was a problem hiding this comment.
Yes, that's what I meant. But the main rationale would be to have the semicolon in user code. A casual reader might not 'know' that HPX_FALLTHROUGH is a macro...
There was a problem hiding this comment.
I agree, thanks for the review! Fixed.
|
FWIW: this describes how things are implemented in gcc: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ |
Adds a feature test for C++17
[[fallthrough]]and removes gcc 7.1 warnings complaining about a possible fallthrough.