Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpx::partitioned_vector serializer #2762

Merged
merged 19 commits into from Aug 2, 2017

Conversation

ct-clmsn
Copy link
Contributor

@ct-clmsn ct-clmsn commented Jul 17, 2017

PR for issue #1645

@ct-clmsn ct-clmsn changed the title partitioned_vector serializer hpx::partitioned_vector serializer Jul 17, 2017
@ct-clmsn
Copy link
Contributor Author

@hkaiser @sithhell libhpx_partitioned_vector isn't correctly linked by cmake into the serialized partitioned_vector unit test. The unit test can be built manually using hpxcxx without error. I've reviewed the partitioned_vector unit tests and haven't been able to sort out what needs to be added into cmake to fix the linking issue - do ya'll have any tips or suggestions?

@hkaiser
Copy link
Member

hkaiser commented Jul 27, 2017

@ct-clmsn In theory it is sufficient to declare the partitioned_vector_component as a dependency, but that has been done. I have no idea right away, but I'll have a look.

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Aug 1, 2017

@hkaiser thanks!

@hkaiser
Copy link
Member

hkaiser commented Aug 1, 2017

@ct-clmsn There was a problem in the segmented parallel::fill implementation which was causing your linker errors. I added a commit to your branch here: e1cc39c. If this goes through now we can merge things from that branch. Thanks for your patience!

@hkaiser
Copy link
Member

hkaiser commented Aug 2, 2017

@ct-clmsn I have updated the commit mentioned above (see a5b25d0). I hope you don't mind me slightly simplifying your implementation... Things should be ready for merging now.

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Aug 2, 2017

@hkaiser apologies for unnecessary complexity! i had concerns the most straight forward implementation might miss some compile-time nuances of the platform.

@hkaiser
Copy link
Member

hkaiser commented Aug 2, 2017

@ct-clmsn No apologies needed. Sometimes the simplest solution turns out to be the best in the end... The main issue was that bug in parallel::fill we had - this probably has thrown you off. Thanks again for your contributions!

@hkaiser hkaiser merged commit 5845fa0 into STEllAR-GROUP:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants