Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unmatched header defines and recursive inclusion of threadmana… #2861

Merged
merged 1 commit into from Aug 29, 2017

Conversation

hendrx
Copy link
Contributor

@hendrx hendrx commented Aug 25, 2017

…ger.hpp in threadmanager.hpp

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

One minor comment: we usually add our names to files whenever we have either created the file or have changed/contributed at least 20% of its content.

@hendrx
Copy link
Contributor Author

hendrx commented Aug 27, 2017

Sorry hartmut, i think i have misinterpreted the name in the file thing then. i thought we had to change the name thing as soon as we get involved in a file, i thought it was a thing to identify and blame people in case some stuff goes wrong, so more like a obligatory requirement.

i am happy to not show up, as i didnt really contribute but just changed a minor thing :D

@hkaiser
Copy link
Member

hkaiser commented Aug 27, 2017

@hendrx No problem at all!

@hendrx hendrx force-pushed the fixing_threadmanager_hpp_headers branch from d228f75 to cfd1f27 Compare August 28, 2017 08:41
@sithhell sithhell merged commit 93a6bc8 into master Aug 29, 2017
@sithhell sithhell deleted the fixing_threadmanager_hpp_headers branch August 29, 2017 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants