Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Partitioner Fixes #2891

Merged
merged 9 commits into from Sep 22, 2017
Merged

Resource Partitioner Fixes #2891

merged 9 commits into from Sep 22, 2017

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented Sep 7, 2017

This patchset provides the following:

  • When registering new threads without executors, the thread pool the current thread is running on is taken into account instead of always using the default pool.
  • A test-case for dynamic removal and addition of PUs to a pool has been. Various problems to support this functionality fully have been fixed in the process
  • implemented hpx::threads::get_numa_domain()

Thomas Heller added 6 commits September 6, 2017 12:18
 - Fixing scheduling loop such that it can exit even though there are still
   threads globally available
 - Fixing the thread pool to be thread safe when changing the number of used
   resources
 - Various fixes in the thread pools to properly handle dynamic resource
   management
 - Fixing scheduling policies such that they don't schedule tasks on disabled
   cores
The check if a core is disabled needs to honor the thread offset
@sithhell
Copy link
Member Author

sithhell commented Sep 7, 2017

This also includes the commits from #2878

 - Decreasing line length
 - Adding missing includes
@biddisco
Copy link
Contributor

I have added a commit to fix #2899 - numa balanced mode for hpx:bind

@biddisco
Copy link
Contributor

Note: numa-balanced commit moved back to it's own PR after request from @sithhell

@biddisco biddisco added this to Work in Progress in resource partitioner/manager work Sep 12, 2017
Thomas Heller added 2 commits September 15, 2017 07:50
Conflicts:
	tests/unit/resource/CMakeLists.txt
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 1dad7f4 into master Sep 22, 2017
@hkaiser hkaiser deleted the throttle_cores branch September 22, 2017 18:18
@biddisco biddisco moved this from Work in Progress to completed in resource partitioner/manager work Oct 11, 2017
sithhell pushed a commit that referenced this pull request Oct 17, 2017
 - Partially reverting changes to wait_or_add_new and the termination detection
 - Commenting out throttle test, to be fixed within #2955
hkaiser added a commit that referenced this pull request Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants