Fixing CUDA problems #2911
Merged
Fixing CUDA problems #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch properly defines the macros needed for properly supporting clang-cuda builds.
Some code in the binpacking distribution policy produced ICEs in the nvcc frontend. This code has been put into a different TU such that it doesn't need to be processed by nvcc.
hkaiser
reviewed
Sep 21, 2017
hpx/config/forceinline.hpp
Outdated
| # endif | ||
| // # else | ||
| // # define HPX_FORCEINLINE inline | ||
| // # endif |
There was a problem hiding this comment.
This breaks the build on non-gcc compatible platforms.
sithhell
commented
Sep 29, 2017
hpx/config/forceinline.hpp
Outdated
| // # endif | ||
| # else | ||
| # define HPX_FORCEINLINE inline | ||
| # endif |
There was a problem hiding this comment.
Thanks, this was only commented by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues related to building HPX applications with either nvcc or cuda-clang