Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #include files needed to set _POSIX_VERSION for debug check #2930

Merged
merged 1 commit into from Oct 5, 2017

Conversation

biddisco
Copy link
Contributor

@biddisco biddisco commented Oct 4, 2017

Debugger was not being attached because the relevant code was #ifdef'ed
out and therefore being skipped completely on some linux flavours

fix #2924 problem seems to have been caused by changes introduced in #2830

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -9,10 +9,19 @@

#include <iostream>

#if !defined(_WIN32) && (defined(__unix__) || defined(__unix) || (defined(__APPLE__) && defined(__MACH__)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a macro to check if it exists or not: #ifdef HPX_HAVE_UNISTD_H
please use that instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I pasted that from another file, so maybe I should also change that one ...

Debugger was not being attached because the relevant code was #ifdef'ed
out and therefore being skipped completely on some linux flavours
@biddisco biddisco merged commit d8aa59a into master Oct 5, 2017
@biddisco biddisco deleted the fixing_2924 branch October 5, 2017 12:20
@msimberg msimberg added this to the 1.1.0 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hpx:attach-debugger=startup does not work any more
4 participants