Removing wrong call to cleanup_terminated_locked #2952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code removed was accidently added and shouldn't have been there in the first place
hkaiser
reviewed
Oct 16, 2017
| else if ((scheduler.get_scheduler_mode() & policies::fast_idle_mode) || | ||
| idle_loop_count > params.max_idle_loop_count_ || may_exit) | ||
| else if (((scheduler.get_scheduler_mode() & policies::fast_idle_mode) || | ||
| (idle_loop_count > params.max_idle_loop_count_)) || may_exit) |
There was a problem hiding this comment.
The outer pair of parenthesis is superfluous.
hkaiser
reviewed
Oct 16, 2017
| thread_init_data background_init( | ||
| [&, background_running](thread_state_ex_enum) -> thread_result_type | ||
| [&idle_loop_count, bg_callback, background_running](thread_state_ex_enum) -> thread_result_type |
This fixes the hangs we recently encountered
sithhell
force-pushed
the
fix_thread_map
branch
from
36544eb
to
10d0dd1
Compare
|
Superseded by #2962. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code removed was accidently added and shouldn't have been there in the
first place