Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding non-blocking (on destruction) service executors #2992

Merged
merged 1 commit into from Nov 11, 2017
Merged

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Nov 6, 2017

  • implement run_as_os_thread in terms of non-blocking io_pool executor

this fixes #2991

@hkaiser
Copy link
Member Author

hkaiser commented Nov 6, 2017

@maciekab could you please check whether this fixes the issue you reported?

Copy link
Member

@maciekab maciekab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a Executor::detach function work as well?
I don't like the non_blocking suffix for the executor. This term has other meanings as well, for example non blocking for a enqueue operation.

@hkaiser
Copy link
Member Author

hkaiser commented Nov 6, 2017

Wouldn't a Executor::detach function work as well?

Good thinking. I'll make those changes...

- implement run_as_os_thread in terms of non-blocking io_pool executor
@hkaiser
Copy link
Member Author

hkaiser commented Nov 6, 2017

@sithhell better now?

Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@hkaiser hkaiser merged commit a7e2523 into master Nov 11, 2017
@hkaiser hkaiser deleted the fixing_2991 branch November 11, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_as_os_thread locks up
3 participants