Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A strange thing in parallel::sort. #3088

Closed
taeguk opened this issue Jan 1, 2018 · 0 comments
Closed

A strange thing in parallel::sort. #3088

taeguk opened this issue Jan 1, 2018 · 0 comments

Comments

@taeguk
Copy link
Member

taeguk commented Jan 1, 2018

if (result.has_exception())
{
return detail::handle_exception<ExPolicy, RandomIt>::call(
std::move(result));
}

result(hpx::future) is returned from execution::async_execute(). So, if the task is running, result.has_exception() always returns false.

As I think, that code block(L210-L214) is not necessary because anyhow the exception which is occurred in the task is wrapped into the future(result).

@hkaiser hkaiser added this to the 1.2.0 milestone Jan 1, 2018
taeguk added a commit to taeguk/hpx that referenced this issue Jan 1, 2018
There are some changes in parallel::sort for fixing STEllAR-GROUP#2834.
And this commit also fixes STEllAR-GROUP#3088.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants