Adapting stack overhead limit for gcc 4.9 #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adapts the compile time constant for the stack overhead for gcc 4.9. This unbreaks the thread_stacksize test.
sithhell
added
type: defect
category: actions
difficulty: easy
hkaiser
requested changes
Jan 12, 2018
|
The thread stack specific config has been factored out. |
This was referenced Jan 15, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #3044
Proposed Changes
This patch adapts the compile time constant for the stack overhead for gcc 4.9.
This unbreaks the thread_stacksize test.
Any background context you want to provide?
HPX tasks are suspect to stack overflows. Currently, the thread_stacksize test fails with a segfault. It is trying to touch all bytes in the stack. It relies on the
HPX_THREADS_STACK_OVERHEADdefine to have a sensible value. This value was to small for gcc 4.9.