Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused scoped_unlock, unlock_guard_try #3185

Merged
merged 1 commit into from Mar 8, 2018
Merged

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Feb 20, 2018

No description provided.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a

#if defined(HPX_HAVE_SCOPED_LOCK_COMPATIBILITY)
template <typename Lock>
using scoped_unlock<Lock> = unlock_guard<Lock>;
#endif

and follow the usual deprecation steps instead of just dropping scoped_unlock without proper phasing-out?

@K-ballo
Copy link
Member Author

K-ballo commented Feb 24, 2018

Should we add a

#if defined(HPX_HAVE_SCOPED_LOCK_COMPATIBILITY)
template <typename Lock>
using scoped_unlock<Lock> = unlock_guard<Lock>;
#endif

and follow the usual deprecation steps instead of just dropping scoped_unlock without proper phasing-out?

Sounds good, specially if compatibility defaults to OFF.

@K-ballo
Copy link
Member Author

K-ballo commented Mar 6, 2018

Added deprecation compatibility flag.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants