@@ -1,3 +1,4 @@ +* Fix space-ridden USPS usernames when validating credentials [james] * Remove extra slash from USPS URLs [james] * Update Shipwire endpoint hostname [cody] * Add missing ISO countries [Edward Ocampo-Gooding] CHANGELOG @@ -186,7 +186,7 @@ module ActiveMerchant # Once the address verification API is implemented, remove this and have valid_credentials? build the request using that instead. def canned_address_verification_works? - request = "%3CCarrierPickupAvailabilityRequest%20USERID=%22#{@options[:login]}%22%3E%20%0A%3CFirmName%3EABC%20Corp.%3C/FirmName%3E%20%0A%3CSuiteOrApt%3ESuite%20777%3C/SuiteOrApt%3E%20%0A%3CAddress2%3E1390%20Market%20Street%3C/Address2%3E%20%0A%3CUrbanization%3E%3C/Urbanization%3E%20%0A%3CCity%3EHouston%3C/City%3E%20%0A%3CState%3ETX%3C/State%3E%20%0A%3CZIP5%3E77058%3C/ZIP5%3E%20%0A%3CZIP4%3E1234%3C/ZIP4%3E%20%0A%3C/CarrierPickupAvailabilityRequest%3E%0A" + request = "%3CCarrierPickupAvailabilityRequest%20USERID=%22#{URI.encode(@options[:login])}%22%3E%20%0A%3CFirmName%3EABC%20Corp.%3C/FirmName%3E%20%0A%3CSuiteOrApt%3ESuite%20777%3C/SuiteOrApt%3E%20%0A%3CAddress2%3E1390%20Market%20Street%3C/Address2%3E%20%0A%3CUrbanization%3E%3C/Urbanization%3E%20%0A%3CCity%3EHouston%3C/City%3E%20%0A%3CState%3ETX%3C/State%3E%20%0A%3CZIP5%3E77058%3C/ZIP5%3E%20%0A%3CZIP4%3E1234%3C/ZIP4%3E%20%0A%3C/CarrierPickupAvailabilityRequest%3E%0A" # expected_hash = {"CarrierPickupAvailabilityResponse"=>{"City"=>"HOUSTON", "Address2"=>"1390 Market Street", "FirmName"=>"ABC Corp.", "State"=>"TX", "Date"=>"3/1/2004", "DayOfWeek"=>"Monday", "Urbanization"=>nil, "ZIP4"=>"1234", "ZIP5"=>"77058", "CarrierRoute"=>"C", "SuiteOrApt"=>"Suite 777"}} xml = REXML::Document.new(commit(:test, request, true)) xml.get_text('/CarrierPickupAvailabilityResponse/City').to_s == 'HOUSTON' && lib/active_shipping/shipping/carriers/usps.rb e31bedd294065a1140974518bc66ced374713812 James MacAulay james@jadedpixel.com http://github.com/Shopify/active_shipping/commit/c56579c934ed5b80d16339242ef264a24bdb3a21 c56579c934ed5b80d16339242ef264a24bdb3a21

2009-05-22T14:41:18-07:00

Fix space-ridden USPS usernames when validating credentials 33e7cf0608068dbe6a7a99c258bc42d4c3735e4f James MacAulay james@jadedpixel.com