Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect Settlements with Roads #44

Merged
merged 9 commits into from Jul 5, 2019
Merged

Connect Settlements with Roads #44

merged 9 commits into from Jul 5, 2019

Conversation

mayant15
Copy link
Contributor

@mayant15 mayant15 commented Jun 21, 2019 •
edited

This PR will create roads connecting cities.

TO TEST:

  1. Launch a new game with an implementation of DynamicCities
  2. Find at least two cities
  3. Straight roads connecting settlements will be built

Roads
close

@mayant15
Setup road construction pipeline
5854f27 
 - Created basic container classes
 - Created temporary mock functions
 - Setup SettlementEntityManager to create roads as it creates buildings
@mayant15
Calculate and place RoadParcels between settlements
7132774
@mayant15
Add a rasterizer to place blocks
7233d6e
@mayant15
Better place and clear out space for roads
e5961d7 
- Buildings of the source will not be built upon roads
- RoadSegments will be laid down better
@mayant15
Add gravel blocks to road
2961a63
@mayant15
Add road rasterizer and theme to construction system
68344df
@mayant15
Create roads from the nearest city only
2cd9199
@mayant15
Clean up code
743fdb8
@mayant15 mayant15 changed the title [WIP] Connect Settlements with Roads Connect Settlements with Roads Jun 29, 2019
Cervator
Cervator approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran over the changes real quick and verified it doesn't seem to cause crashes (an older DC issue did though). Having a hard time finding good test worlds, I suggest adding in test seeds in future PRs for easier testing :-)

@Cervator Cervator merged commit a9e68a3 into Terasology:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iaronaraujo iaronaraujo iaronaraujo requested changes

@Cervator Cervator Cervator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mayant15 @Cervator @iaronaraujo