Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused dependencies #111

Closed
ppisar opened this issue Aug 1, 2019 · 4 comments
Closed

Unused dependencies #111

ppisar opened this issue Aug 1, 2019 · 4 comments

Comments

@ppisar
Copy link
Contributor

ppisar commented Aug 1, 2019

When packaging Test2-Harness for Fedora Linux distribution I noticed that following dependencies are declared but not used in the code:

Filter::Util::Call
Symbol
Test2
Test2::Event::V2

These should be moved from runtime to develop:

Test2::Require::Module

@ppisar
Copy link
Contributor Author

ppisar commented Aug 2, 2019

And List::Util is underspecified. META requires 1.44 version while lib/Test2/Harness/Util/TestFile.pm:13 required 1.45.

@exodist
Copy link
Member

exodist commented Aug 2, 2019

Filter::Util::Call is used by a dep, goto::file. But yeah, the dep should be listed there, not here.
hmm, I am surprised Test2::Event::V2 is not used in the code, like that may mean there is a bug, I have to look into that.

Thanks for the report! I will try to make time to fix this soon.

@ppisar
Copy link
Contributor Author

ppisar commented Aug 19, 2019

Test2-Harness-0.001083 added a useless dependency on Test2::Plugin::DBIProfile. While the other two split ones are indeed passed to a perl command arguments, the DBIProfile does not seem to be used anywhere.

@exodist
Copy link
Member

exodist commented Aug 19, 2019

Not used yet. I am still implementing the feature. I decided to move DBIProfile out before completing the feature so that I could use it without Test2::Harness. When I am done there will be a cli option to enable it.

exodist added a commit that referenced this issue Aug 21, 2019
    - Do not require DBIProfile yet until we need it (#111)
    - Standardize how fields are specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants