Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the [SKIP!!] non-verbose line doesn't give reason #21

Closed
rjbs opened this issue Dec 20, 2016 · 3 comments
Closed

the [SKIP!!] non-verbose line doesn't give reason #21

rjbs opened this issue Dec 20, 2016 · 3 comments

Comments

@rjbs
Copy link
Contributor

rjbs commented Dec 20, 2016

Example! With prove:

~$ prove skip-all.pl
skip-all.pl .. skipped: meh
Files=1, Tests=0,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.05 cusr  0.01 csys =  0.09 CPU)
Result: NOTESTS

With yath:

~$ yath skip-all.pl
[SKIP!!]  =  skip-all.pl

=== ALL TESTS SUCCEEDED ===

Also, note the distinction between NOTESTS and ALL TESTS SUCCEEDED.
@autarch
Copy link
Contributor

autarch commented Dec 20, 2016

Some of this may have started with my recent changes. I'll investigate.

@autarch
Copy link
Contributor

autarch commented Dec 20, 2016

Looks like neither of these things are caused by my changes. I agree they should both be fixed.

@autarch
Copy link
Contributor

autarch commented Dec 20, 2016

Hmm, actually, with the latest release I get this:

[PASSED]  =  ./skip-all.t passed

=== ALL TESTS SUCCEEDED ===

So clearly there's a regression here.

@autarch autarch mentioned this issue Dec 20, 2016
Merged
exodist added a commit that referenced this issue Jan 4, 2017
@exodist
v0.000013
ed1289c 
    - Add event timeout option
    - Fix filename rendering when a test is done
    - Fixed handling of a "plan skip_all" issued in the main test (as opposed
      to a subtest). Partially fixes GitHub
      #21, reported by rjbs.
    - When a test file doesn't run any tests but exits successfully, this was
      treated as a pass. This is now detected and generates different output
      indicating that the process did not run any tests. Fixes the rest of
      GitHub #21, reported by rjbs.
@autarch autarch closed this as completed Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjbs @autarch