Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-subtest callbacks #801

Merged
merged 1 commit into from Nov 21, 2017
Merged

add pre-subtest callbacks #801

merged 1 commit into from Nov 21, 2017

Conversation

dakkar
Copy link
Contributor

@dakkar dakkar commented Nov 21, 2017

as suggested in #800

Test2::API now has pre-subtest callbacks.

I'm not sure that the way I wrote the t/Legacy/subtest/callback.t is the best way, I'm not clear on what I can and can not use.

@exodist
Copy link
Member

exodist commented Nov 21, 2017

This looks perfectly fine to me. And it opens the door for your plugin, and possibly other handy ones.

@exodist exodist merged commit dc39979 into Test-More:master Nov 21, 2017
@exodist
Copy link
Member

exodist commented Nov 21, 2017

I just uploaded a TRIAL to cpan with this. Assuming no complaints for a couple days I will go ahead and release as stable. I am also running my own gauntlet of downstream tests too look for breakages.

exodist added a commit that referenced this pull request Nov 23, 2017
    - Added pre-subtest hook to Test2::API (#801 from dakkar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants