Tobbe / losi

Doing a standard/default install LOSI 0.4 (and 0.4.5) crashes right after copying all files (after the InstFiles page) if the user has an apostrophe in his username.

If you chose to install LiteStep for all users (=setting the shell in HKLM) any new users added to the computer after the LiteStep install will not have a working shell. They will get LiteStep error messages complaining about a missing ThemeDir.

Right now SectionCore installs LiteStep core files, a few modules and the OTS folder structure.

This should be split to a SectionCore and a SectionOTS (section OTS would also install the modules). Maybe even split it to SectionCore, SectionOTS, and SectionModules

InstFiles should be called as late as possible during installation. The reason for this is that you can't cleanly cancel the installation after InstFiles has run. InstFiles is the page that copies all the files to the installation directory.

NSIS now comes with an official header for checking Windows version. LOSI should switch to using that instead of the custom header it's currently using.

After installing LOSI to C:\Program\LiteStep and then to C:\LOSI and finally uninstalling LOSI from C:\LOSI I got the following error when trying to set LiteStep as the shell from the start menu icon:

---------------------------
wxLua Error
---------------------------
lua: Error while running chunk
C:\Program\LiteStep\utilities\LOSS.lua:124: attempt to index global 'hkey' (a nil value)
stack traceback:
    C:\Program\LiteStep\utilities\LOSS.lua:124: in function 'getLitestepPath'
    C:\Program\LiteStep\utilities\LOSS.lua:278: in main chunk

---------------------------
OK   
---------------------------

It's possible the user removed the previous shell after installing LiteStep.

Go back to the previous shell when uninstalling if that .exe file still exists, otherwise go back to explorer and reset all registry entries to default.

Maybe some descriptive text is needed and/or a rewording of the options.

For example "Only for the currently logged in user" make it seem like no one else will be able to use this particular LiteStep installation.

Whereas "For all users on the computer" sounds more like what people would want, but they may not realize that everyone's shell will automatically become LiteStep.

And the third option sounds like what the 2nd option actually is.

1st Option: Set LiteStep as default system shell for all users. (Only select this if you do not want to enable profile support in the next page)

2nd Option: Set LiteStep as the shell for the current user. (LiteStep may be set as the shell for other users in the future as well)

3rd Option: Do not set LiteStep as the shell at this time. (File installation only, no systems settings will be changed)

[jugg]

If LiteStep is detected as running during the installation it will be !quit without first telling the user about this.

It would be nicer to inform the user that LiteStep will be shut down, and why this is necessary before killing it. This should be implemented on a separate page in the installer.

This only applies when installing while another instance of LiteStep is already running.

Definite bug here. Because the evars were configured After the LOSI litestep was launched, none of their settings took affect. For example, I was just trying to figure out why notepad was being launched when I tried to open the $txteditor$, and looking at !alert "$txteditor$" showed that it was configured as "notepad", yet that is not what "evars.rc" had defined. Quite confusing at first. [jugg]

This will have to be solved either by configuring the evars before launching LiteStep, or by calling !recycle after updating the evars.

Don't kill the current shell (unless we're upgrading/updating) and don't start LS until the very last page of the installer where there should be an option to start LS or not.

Investigate what happens if the user continues to run Explorer (or bb4win) when LiteStep is set as the shell.

Make the Profiles page show the actual paths that will be used when installing. ($INSTDIR should already be set to the correct value)

If an old evars.rc is found it should be parsed and as many values as possible should be used. These values should be the suggestions for the evar config pages.

The evars.rc file should be searched for in the directory LOSI is being installed to and in any other LiteStep folder the installer finds.

Sanity checks should be made on all paths so they actually point to an executable file.

Sometimes a few files are left behind after uninstalling LiteStep.

I have not been able to find the cause of this.

To solve this bug I need to find a way to reliably reproduce this.

It seems like LOSI can't kill explorer.exe under certain circumstances.

I think it is when I Install LOSI -> Uninstall LOSI and then try to install LOSI again. The second time I install LOSI explorer doesn't die on the finish page of the installer.

Fix by running

taskkill /f /im explorer.exe

if taskkill exists on the current OS. If it doesn't exist we have to ask the user to manually kill explorer.

The WhereProfiles page should only be shown if the OTS files are selected for installation.

I only checked "Configure Evars" when installing, and I choose to not have any support for profiles. The install log says the following:

Målkatalog: C:\Program\LiteStep\Profiles\Tobbe\themes
Extrahera: themeselect.rc... 100%
Extrahera: themeslist.rc... 100%
Målkatalog: C:\Program\LiteStep
Slutförd

Those files shouldn't be extracted at all since I didn't choose to install the OTS files or the Theme files.

The default step.rc in LOSI has the following line:

include "$ThemeDir$config_compatibility_patch.rc"

This is only needed for OTS1 themes. However, the remainder of the step.rc does not implement the necessary architecture for complete support of an OTS1 theme.

I suggest removing that include line all together and moving the themeselect.rc include line right above the remaining include lines.

Test and make sure that a module built with VC9 runs on a machine that only has the vc9 sp1 redist installed. If it does, LOSI should recommend installing only vc9 sp1, if it doesn't both vc9 redists and vc9 sp1 redists should be recommended.

If LiteStep is used by multiple users on the computer and one of the users uninstalls it, it will be uninstalled for all users.

Detect/keep track of how many users are using LiteStep. Maybe by looking at how many profiles folders there are. Allow the user to choose if he wants to completely remove LS or just uninstall it for himself.

Add another page to the uninstaller where the user is asked what files to keep and what files to remove. Do this to get rid of the message boxes currently shown during the removal of the installed files.

The HowLS page should only be shown if SectionCore is selected.

Copy the msvcp???.dll files to $litestepdir$ instead of system32 (check system32 if they already exists first)

When I double click .rc files they open in Notepad. They should open in the program I have associated with .txt files.

When I double click .txt files they open in Notepad++.

The evars configuration dialog properly identified Notepad++ as my text editor.

Switch to /refreshsilent and add [!recycle] to the popup command.

In Windows Vista and 7 you get a "This program might not have installed correctly" message when closing the installer.

Add RequestExecutionLevel to the nsis script to fix this