Navigation Menu

Skip to content

Commit

Permalink
docs: better comment in strictNullCheck action (#3198)
Browse files Browse the repository at this point in the history
## About the changes
This is a small improvement adding more context to the comment message
when this action fails. 

---------

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
  • Loading branch information
Gastón Fournier and thomasheartman committed Feb 27, 2023
1 parent ef2f184 commit 2e749a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/gradual-strict-null-checks.yml
Expand Up @@ -66,7 +66,7 @@ jobs:
MAIN=$(grep "Found [0-9]* errors" .out-main | sed 's/Found \(.*\) errors in .* files./\1/')
if [ $CURRENT -gt $MAIN ]; then
comment "After enabling strictNullChecks this PR would be increasing the number of null check errors from ${MAIN} to ${CURRENT}. Make sure your branch is up-to-date with ${MAIN_BRANCH} and check the diff in the console output to gather more details"
comment "After enabling [\`strictNullChecks\`](https://www.typescriptlang.org/tsconfig#strictNullChecks) this PR would be **increasing** the number of null check errors from ${MAIN} to ${CURRENT}. <br /> Make sure your branch is up-to-date with ${MAIN_BRANCH} and **check the diff in the console output** to gather more details."
diff .out-current .out-main
exit 1
else
Expand Down

0 comments on commit 2e749a2

Please sign in to comment.