From 3e186f1986df4c24f9702d7fa93358d5c0aeb9aa Mon Sep 17 00:00:00 2001 From: Mateusz Kwasniewski Date: Mon, 15 Jan 2024 15:10:15 +0100 Subject: [PATCH] chore: remove schedulers (#5895) --- src/lib/__snapshots__/create-config.test.ts.snap | 1 + src/lib/create-config.ts | 6 ++++++ src/lib/features/scheduler/schedule-services.ts | 16 ---------------- src/lib/types/option.ts | 2 ++ 4 files changed, 9 insertions(+), 16 deletions(-) diff --git a/src/lib/__snapshots__/create-config.test.ts.snap b/src/lib/__snapshots__/create-config.test.ts.snap index 1fc0fb1b3f3..676e392d458 100644 --- a/src/lib/__snapshots__/create-config.test.ts.snap +++ b/src/lib/__snapshots__/create-config.test.ts.snap @@ -29,6 +29,7 @@ exports[`should create default config 1`] = ` "enabled": true, "maxAge": 3600000, }, + "dailyMetricsStorageDays": 31, "db": { "acquireConnectionTimeout": 30000, "applicationName": "unleash", diff --git a/src/lib/create-config.ts b/src/lib/create-config.ts index 1c3fd35e0a4..4cc2ff2c01b 100644 --- a/src/lib/create-config.ts +++ b/src/lib/create-config.ts @@ -551,6 +551,11 @@ export function createConfig(options: IUnleashOptions): IUnleashConfig { const feedbackUriPath = process.env.FEEDBACK_URI_PATH; + const dailyMetricsStorageDays = Math.min( + parseEnvVarNumber(process.env.DAILY_METRICS_STORAGE_DAYS, 31), + 92, + ); + return { db, session, @@ -587,6 +592,7 @@ export function createConfig(options: IUnleashOptions): IUnleashConfig { metricsRateLimiting, rateLimiting, feedbackUriPath, + dailyMetricsStorageDays, }; } diff --git a/src/lib/features/scheduler/schedule-services.ts b/src/lib/features/scheduler/schedule-services.ts index 7e6fad7dcb4..0e276270c90 100644 --- a/src/lib/features/scheduler/schedule-services.ts +++ b/src/lib/features/scheduler/schedule-services.ts @@ -145,22 +145,6 @@ export const scheduleServices = async ( 'clearMetrics', ); - schedulerService.schedule( - () => { - clientMetricsServiceV2.clearDailyMetrics(92).catch(console.error); - }, - hoursToMilliseconds(24), - 'clearDailyMetrics', - ); - - schedulerService.schedule( - () => { - clientMetricsServiceV2.aggregateDailyMetrics().catch(console.error); - }, - hoursToMilliseconds(24), - 'aggregateDailyMetrics', - ); - schedulerService.schedule( accountService.updateLastSeen.bind(accountService), minutesToMilliseconds(3), diff --git a/src/lib/types/option.ts b/src/lib/types/option.ts index f43dbe4e5c6..462e919580c 100644 --- a/src/lib/types/option.ts +++ b/src/lib/types/option.ts @@ -133,6 +133,7 @@ export interface IUnleashOptions { publicFolder?: string; disableScheduler?: boolean; metricsRateLimiting?: Partial; + dailyMetricsStorageDays?: number; rateLimiting?: Partial; } @@ -236,6 +237,7 @@ export interface IUnleashConfig { segmentValuesLimit: number; strategySegmentsLimit: number; metricsRateLimiting: IMetricsRateLimiting; + dailyMetricsStorageDays: number; clientFeatureCaching: IClientCachingOption; accessControlMaxAge: number; prometheusApi?: string;