Skip to content

Commit

Permalink
fix: notifications tables drop order (#3186)
Browse files Browse the repository at this point in the history
Since `user_notifications` references `notifications`, it makes sense to
drop `user_notifications` before dropping `notifications` and not the
other way around. This should fix the failing tests on Enterprise with
latest main.

Thanks @gastonfournier for the help finding the bug 👍
  • Loading branch information
nunogois committed Feb 23, 2023
1 parent bc72e9c commit 7629fcb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/migrations/20230222154915-create-notiications-table.js
Expand Up @@ -25,8 +25,9 @@ exports.up = function (db, cb) {
exports.down = function (db, cb) {
db.runSql(
`
DROP TABLE IF EXISTS user_notifications;
DROP TABLE IF EXISTS notifications;
DROP TABLE IF EXISTS user_notifications;`,
`,
cb,
);
};

0 comments on commit 7629fcb

Please sign in to comment.