From e6f3b3009a529438b292145e88c7594a2879b557 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= Date: Tue, 18 Apr 2023 14:42:49 +0200 Subject: [PATCH] fix: missing node engine upgrade to 18 (#3552) ## About the changes Updates frontend engine minimum version to node 18 and also improves some messages in the release GHA task --- .github/workflows/release.yaml | 11 ++++++++--- frontend/package.json | 2 +- package.json | 4 +++- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index a3e365e05db..ab60b3ea867 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -14,16 +14,21 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Publish to npm + - name: Setup to npm uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' cache: 'yarn' - - run: | + - name: Build + run: | yarn install --frozen-lockfile yarn --cwd ./frontend install --frozen-lockfile - - run: | + ls -l ./frontend + ls -l ./frontend/build + npm publish --dry-run + - name: Publish to npm + run: | LATEST=$(npm show unleash-server version) TAG=$(node scripts/npm-tag.js $LATEST) npm publish --tag ${TAG:-latest} diff --git a/frontend/package.json b/frontend/package.json index 503a47fb477..ebe1b1dc188 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -7,7 +7,7 @@ "build/" ], "engines": { - "node": ">=14" + "node": ">=18" }, "scripts": { "build": "vite build", diff --git a/package.json b/package.json index b7c2bf70dc5..ae925f6f0dc 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,9 @@ "files": [ "dist", "docs", - "frontend/build" + "frontend/build", + "frontend/index.js", + "frontend/package.json" ], "repository": { "type": "git",