Reference ourselves and fix most issues.

Author: Hosch250

VSDiagnostics/VSDiagnostics/VSDiagnostics.Test/Tests/Utilities/ExtensionsTests.cs

@@ -528,10 +528,7 @@ private static void AssertMethodIsDefinedInAncestor(string source)
             Assert.IsTrue(methodSymbol.IsDefinedInAncestor());
         }
 
-        private static IEnumerable<MethodDeclarationSyntax> GetMethodNodes(SyntaxTree tree)
-        {
-            return tree.GetRoot().DescendantNodes().OfType<MethodDeclarationSyntax>();
-        }
+        private static IEnumerable<MethodDeclarationSyntax> GetMethodNodes(SyntaxTree tree) => tree.GetRoot().DescendantNodes().OfType<MethodDeclarationSyntax>();
 
         private static SemanticModel GetSemanticModel(SyntaxTree tree)
         {

VSDiagnostics/VSDiagnostics/VSDiagnostics.Test/Tests/Utilities/NamingConventionsTests.cs

@@ -166,6 +166,7 @@
   <ItemGroup>
     <Analyzer Include="..\..\packages\Microsoft.CodeAnalysis.Analyzers.1.0.0\analyzers\dotnet\cs\Microsoft.CodeAnalysis.Analyzers.dll" />
     <Analyzer Include="..\..\packages\Microsoft.CodeAnalysis.Analyzers.1.0.0\analyzers\dotnet\cs\Microsoft.CodeAnalysis.CSharp.Analyzers.dll" />
+    <Analyzer Include="..\..\packages\VSDiagnostics.1.9.3\tools\analyzers\VSDiagnostics.dll" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 

VSDiagnostics/VSDiagnostics/VSDiagnostics.Test/VSDiagnostics.Test.csproj

@@ -12,4 +12,5 @@
   <package id="RoslynTester" version="1.6.2" targetFramework="net45" />
   <package id="System.Collections.Immutable" version="1.1.36" targetFramework="net45" />
   <package id="System.Reflection.Metadata" version="1.0.21" targetFramework="net45" />
+  <package id="VSDiagnostics" version="1.9.3" targetFramework="net45" />
 </packages>

VSDiagnostics/VSDiagnostics/VSDiagnostics.Test/packages.config

@@ -24,10 +24,7 @@ internal static DiagnosticDescriptor Rule
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 
-        public override void Initialize(AnalysisContext context)
-        {
-            context.RegisterSyntaxNodeAction(AnalyzeSyntaxNode, SyntaxKind.MethodDeclaration);
-        }
+        public override void Initialize(AnalysisContext context) => context.RegisterSyntaxNodeAction(AnalyzeSyntaxNode, SyntaxKind.MethodDeclaration);
 
         private static void AnalyzeSyntaxNode(SyntaxNodeAnalysisContext context)
         {

VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Async/AsyncMethodWithoutAsyncSuffix/AsyncMethodWithoutAsyncSuffixAnalyzer.cs

@@ -35,9 +35,6 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
         }
 
         private async Task<Solution> AddSuffixAsync(Document document, MethodDeclarationSyntax methodDeclaration, SyntaxNode root,
-            CancellationToken cancellationToken)
-        {
-            return await RenameHelper.RenameSymbolAsync(document, root, methodDeclaration.Identifier, methodDeclaration.Identifier.Text + "Async", cancellationToken);
-        }
+            CancellationToken cancellationToken) => await RenameHelper.RenameSymbolAsync(document, root, methodDeclaration.Identifier, methodDeclaration.Identifier.Text + "Async", cancellationToken);
     }
 }

VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Async/AsyncMethodWithoutAsyncSuffix/AsyncMethodWithoutAsyncSuffixCodeFix.cs

@@ -24,10 +24,7 @@ internal static DiagnosticDescriptor Rule
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 
-        public override void Initialize(AnalysisContext context)
-        {
-            context.RegisterSyntaxNodeAction(AnalyzeSyntaxNode, SyntaxKind.MethodDeclaration);
-        }
+        public override void Initialize(AnalysisContext context) => context.RegisterSyntaxNodeAction(AnalyzeSyntaxNode, SyntaxKind.MethodDeclaration);
 
         private static void AnalyzeSyntaxNode(SyntaxNodeAnalysisContext context)
         {

VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Async/SyncMethodWithAsyncSuffix/SyncMethodWithAsyncSuffixAnalyzer.cs

@@ -23,10 +23,7 @@ internal static DiagnosticDescriptor Rule
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 
-        public override void Initialize(AnalysisContext context)
-        {
-            context.RegisterSyntaxNodeAction(AnalyzeCSharpSymbol, SyntaxKind.Attribute);
-        }
+        public override void Initialize(AnalysisContext context) => context.RegisterSyntaxNodeAction(AnalyzeCSharpSymbol, SyntaxKind.Attribute);
 
         private void AnalyzeCSharpSymbol(SyntaxNodeAnalysisContext context)
         {

VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Attributes/AttributeWithEmptyArgumentList/AttributeWithEmptyArgumentListAnalyzer.cs

@@ -23,10 +23,7 @@ internal static DiagnosticDescriptor Rule
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 
-        public override void Initialize(AnalysisContext context)
-        {
-            context.RegisterSyntaxNodeAction(AnalyzeCSharpSymbol, SyntaxKind.EnumDeclaration);
-        }
+        public override void Initialize(AnalysisContext context) => context.RegisterSyntaxNodeAction(AnalyzeCSharpSymbol, SyntaxKind.EnumDeclaration);
 
         private void AnalyzeCSharpSymbol(SyntaxNodeAnalysisContext context)
         {

VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Attributes/EnumCanHaveFlagsAttribute/EnumCanHaveFlagsAttributeAnalyzer.cs

@@ -46,10 +46,7 @@ internal static DiagnosticDescriptor ValuesDontFitRule
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
             => ImmutableArray.Create(DefaultRule, ValuesDontFitRule);
 
-        public override void Initialize(AnalysisContext context)
-        {
-            context.RegisterSyntaxNodeAction(AnalyzeSymbol, SyntaxKind.EnumDeclaration);
-        }
+        public override void Initialize(AnalysisContext context) => context.RegisterSyntaxNodeAction(AnalyzeSymbol, SyntaxKind.EnumDeclaration);
 
         private void AnalyzeSymbol(SyntaxNodeAnalysisContext context)
         {