Use the "old" editor as the freeform block #1394

ellatrix · 2017-06-23T11:40:26Z

Easiest way to add the old editor as a block in Gutenberg (removes a lot of current and future complexity).
With the same setting, plugins that currently work in WP will keep on working.
With some styling, it can fit perfectly well inside Gutenberg.
Can be used on old content without destroying anything.

~~This is still a WIP! 🚧~~

ellatrix · 2017-06-23T12:44:17Z

While still a work in progress, it would be good to get some feedback as this is quite different from the current implementation.

jasmussen · 2017-06-23T12:53:45Z

Very nice! I might have a few suggestions to making the kitchen sink button look closer to how James did it in his approach, and I'd want to separately see how I could make this responsive. But there's nothing about this, visually, that offends :)

Does it work with custom tinymce buttons? (Not that it has to)

BTW I noticed that if you accidentally click the space between the toolbar groups and drag even ever so slightly, you invoke multi select. I think this might be an issue in master also, but figured I'd mention.

@EphoxJames Compared to your branch, what are your thoughts on this one? Is it better or worse, what are the pros and cons from a code simplicity point of view? Thanks so much.

ellatrix · 2017-06-23T13:01:12Z

@jasmussen Yeah it's still a WP. All works like the current editor, just need to add the filter for the buttons, and it will work with custom MCE buttons as well. Not much work.

Regarding the kitchen sink, yes, I'll have see how we can do it better on this branch. Note though that there can be many buttons, and up to 4 toolbars in total (3 additional). We could just merge the additional ones into one, but it will need to wrap in case there are many buttons.

BTW I noticed that if you accidentally click the space between the toolbar groups and drag even ever so slightly, you invoke multi select. I think this might be an issue in master also, but figured I'd mention.

That's only on this branch, because for now, the toolbar is literally part of the content. I'll fix this.

BoardJames

This is great! I like this solution much more than trying to rewrite all the tool bar components in react (which was where I was going to end up).

The only problem I saw aside from those pointed out by @jasmussen is that the kitchen-sink can scroll off the top of the page:

BoardJames · 2017-06-26T03:41:41Z

blocks/library/freeform/old-editor.js

+				content_css: false,
+				fixed_toolbar_container: '#' + id + '-toolbar',
+				toolbar1: 'formatselect | alignleft aligncenter alignright | bullist numlist blockquote | bold italic strikethrough link | kitchensink',
+				toolbar2: 'hr wp_more forecolor pastetext removeformat charmap outdent indent undo redo',


I could not get the wp_more button do do anything. Is it working as intended?

BoardJames · 2017-06-26T04:36:47Z

Another minor difference compared to the other gutenberg blocks is that the controls don't hide while typing and show on mouse move. You can probably fix this and the multi-select issue by putting it into the <BlockControls/> and copying across the relevant code from editable. There's also an issue to delete the freeform block on backspace when there's nothing in it ( #1273 (comment) ).

jasmussen · 2017-06-26T08:05:14Z

Thanks James, appreciate your input. Let's explore this branch further then! 🎉

ellatrix · 2017-06-26T09:16:38Z

I'm aware of the issues, it's also still a WIP. Thanks for the initial feedback, I'll try to get everything working then. One thing that's kind of annoying is trying put the non-React toolbar in the slots, which are always hiding and showing, while MCE's toolbar is supposed to render just once. That's why I've added it to the content div for now. @EphoxJames Ideas welcome. :) It would we nice to get this to work somehow, then we could also show advanced buttons in the inspector, maybe. :) Kind of like #1383. Cc @jasmussen

jasmussen · 2017-06-26T09:27:36Z

One thing that's kind of annoying is trying put the non-React toolbar in the slots, which are always hiding and showing, while MCE's toolbar is supposed to render just once. That's why I've added it to the content div for now.

It's important that we consider code simplicity too. If making the toolbars auto hide for this block adds complexity, maybe we are okay with not adding it for now, or if it can't be done in a nice way_ ever_. It's a tradeoff we're willing to make, and not something that should hold up this PR.

ellatrix · 2017-06-26T11:35:15Z

Okay, I've fixed the wp_more stuff for now here, but ideally should be fixed in core. Will make a patch there.

I've included the plugin and toolbar filters that target the old editor, so that should work now. (Try the TinyMCE Advanced plugin). This will still need further CSS tweaking though, as the toolbars will wrap over a certain length. Maybe scroll like it does in Calypso?

Also still needs the kitchen sink figured out... Also keep in mind that there is a potential menu bar (I've not added that filter yet):

ellatrix · 2017-07-03T09:44:00Z

Sure, okay, but I think we should design for a bit more buttons than that. Additionally there's also a menu bar which will have to go in here as well. We can style the old toolbars in any way we'd like, but I think we should stick with the current layout at least.

jasmussen · 2017-07-03T09:51:40Z

We're sort of in the weeds, design wise, with this one, and I think it would be good to get it stabilized the way you are already doing right now, then merge it in and iterate on it.

But yet another alternative is this:

It's essentially what you had before, but instead of "growing upwards" like I suggested, we embrace that the toolbar wraps downwards, but we add a gray chrome area to the top border to account for the extra padding we need. I know this seems overly complex, but in my head the gray can help explain the discrepancy margins that happens when you select the block.

ellatrix · 2017-07-03T13:42:21Z

#1394 (comment)

Tracking core issue here: https://core.trac.wordpress.org/ticket/41230

ellatrix · 2017-07-03T13:44:22Z

@jasmussen To me, that looks more like a bug than what it looks like now. :) Alternatively, we could not raise the toolbars to the some level as other toolbars, or not raise it if "more" is toggled.

jasmussen · 2017-07-03T13:55:59Z

To clarify a bit on the following:

I imagine the behavior of this mockup to be a dropdown only. That is, if you don't have enough space to see the list buttons, you select text, click the ellipsis, click the list button, and as soon as you've done that the dropdown closes again. So that mockup is not showing a permanently open tray of extra buttons. Just a temporary one. I like this solution because it scales to almost any amount of buttons.

ellatrix · 2017-07-03T14:20:34Z

I'm fine with whatever moves this forward. :) Feel free to adjust any way you'd like.

jasmussen · 2017-07-03T14:27:56Z

I'll take a look, but I think we might want to merge this in soon and then iterate further in other branches.

One thing worth looking at first, though — if you select a freeform block and deselect by clicking on the white area, toolbars and block outlines disappear as they should. But if you deselect by clicking on the gray area of the sidebar, only the toolbar disappears. The block still stays highlighted with block boundaries.

jasmussen · 2017-07-03T14:47:31Z

Another idea, building on your ideas. What if we made an exception to the Gutenberg toolbar style, to truly embrace the "old editor" idea. Basically this:

That way, the toolbar could have the same markup it has in the old editor, and buttons inside could wrap as they do today. What do you think @iseulde ?

ellatrix · 2017-07-03T14:49:50Z

That's good to me. That's the same but without the space in between? What if we just drop the lines as well and have it a full width toolbar (as the old editor)?

ellatrix · 2017-07-03T14:50:57Z

Worth noting that buttons at the top, like the switcher, do different things anyway, even though they look the same. It's not a block switcher or block level alignment.

jasmussen · 2017-07-03T15:15:26Z

That's good to me. That's the same but without the space in between?

Well, the vertical lines could be separators, so it's a single div containing all the elements. Then they would flex wrap, right?

What if we just drop the lines as well and have it a full width toolbar (as the old editor)?

We could do that as well. In fact we might even consider keeping the sort order of the buttons the same as in the old editor.

Full width is also on the table ;) but it's also the last step away from the gutenberg toolbar style. I think we should try and see if we can do without the full width for now.

BoardJames · 2017-07-04T06:44:56Z

I started a branch off this branch to test out some styling ideas "try/freeform-old-editor-floating-toolbar".

It revises the floating toolbar from the first version but uses a "flex-direction: column-reverse" to reverse the toolbar ordering so more than one toolbar can be stacked.

The end result looks the same as the first version except the extra toolbars don't scroll off the top of the page.

ellatrix · 2017-07-07T14:20:15Z

@jasmussen Adjusted based on your feedback. I think this is much better now, and more like the old editor. Still needs some small styling tweaks here and there.

jasmussen

Love it!

I think we're 90% there. I think we should include at least a separator (border-right) on the paragraph dropdown, so it looks like its own thing. Possibly a few more, but if we add that border, it's cool.

This was addressed.

ellatrix · 2017-07-14T12:11:12Z

Okay, let's merge an iterate. This seems to be a good base.

aduth · 2017-07-14T12:16:30Z

blocks/library/freeform/index.js

@@ -20,30 +20,10 @@ registerBlockType( 'core/freeform', {
 	category: 'formatting',

 	attributes: {
-		content: children(),
+		content: prop( 'innerHTML' ),


The html matcher is a shorthand for prop( 'innerHTML' )

https://github.com/aduth/hpq#api

Per effort to discourage treating as DOM node (#624), have considered whether prop can even be dropped.

Ah, didn't realise, sorry. :)

aduth · 2017-07-14T12:21:35Z

blocks/library/freeform/old-editor.js

+			},
+		} );
+
+		/* eslint-disable */


Could we be more specific here with what we're disabling (i.e. list rule names) to avoid introducing errors, and/or a comment to explain why we're disabling.

aduth · 2017-07-14T12:22:16Z

blocks/library/freeform/old-editor.js

+
+			tag = tag || 'more';
+			classname += ' mce-wp-' + tag;
+			title = tag === 'more' ? 'Read more...' : 'Next page';


Should these be translated? Also ellipsis character … as more semantically meaningful than three dots.

As commented, this is just slightly modified core code... I'm even thinking we should drop this and let it fail for the current WordPress version as it is fixed in trunk and will be in 4.9.

…n-new-tab Link target option on Image Block

ellatrix force-pushed the try/freeform-old-editor branch 2 times, most recently from 280bece to e4085b4 Compare June 23, 2017 11:47

ellatrix added [Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Component] TinyMCE [Status] In Progress Tracking issues with work in progress labels Jun 23, 2017

ellatrix force-pushed the try/freeform-old-editor branch 3 times, most recently from 70d8308 to 306be79 Compare June 23, 2017 12:35

ellatrix requested review from youknowriad, mtias, jasmussen and BoardJames June 23, 2017 12:44

BoardJames previously requested changes Jun 26, 2017

View reviewed changes

BoardJames reviewed Jun 26, 2017

View reviewed changes

BoardJames mentioned this pull request Jun 26, 2017

Freeform Block: Add "Kitchen Sink" #1038

Closed

youknowriad mentioned this pull request Jun 26, 2017

Blocks: Try allowing custom buttons in the freeform block #1256

Closed

ellatrix force-pushed the try/freeform-old-editor branch 3 times, most recently from b887e97 to f73110e Compare June 26, 2017 11:26

ellatrix force-pushed the try/freeform-old-editor branch 2 times, most recently from 52cea45 to dbeb663 Compare June 26, 2017 11:51

ellatrix force-pushed the try/freeform-old-editor branch 2 times, most recently from 18592dc to 7e06bc2 Compare July 7, 2017 14:18

jasmussen approved these changes Jul 7, 2017

View reviewed changes

ellatrix mentioned this pull request Jul 8, 2017

Handle unrecognized blocks without modifying their markup #1735

Closed

ellatrix added 3 commits July 14, 2017 13:55

Use exact same old editor for 'classic text' block

7e24416

Alt sticky toolbar

3621522

Support menu bar, adjust toolbar styling

7fc5a0c

ellatrix force-pushed the try/freeform-old-editor branch from 7e06bc2 to 7fc5a0c Compare July 14, 2017 11:59

ellatrix merged commit 57d068b into master Jul 14, 2017

ellatrix deleted the try/freeform-old-editor branch July 14, 2017 12:11

aduth reviewed Jul 14, 2017

View reviewed changes

aduth removed the [Status] In Progress Tracking issues with work in progress label Jul 17, 2017

aduth mentioned this pull request Jul 17, 2017

Propose block APIs for backwards compatibility #413

Closed

ellatrix mentioned this pull request Jul 26, 2017

Fix pasting freeform content #2039

Merged

youknowriad pushed a commit that referenced this pull request Jan 17, 2020

Merge pull request #1394 from wordpress-mobile/issue/1337-link-to-ope…

e3d7753

…n-new-tab Link target option on Image Block

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the "old" editor as the freeform block #1394

Use the "old" editor as the freeform block #1394

ellatrix commented Jun 23, 2017 •

edited

ellatrix commented Jun 23, 2017

jasmussen commented Jun 23, 2017

ellatrix commented Jun 23, 2017 •

edited

BoardJames left a comment

BoardJames Jun 26, 2017

BoardJames commented Jun 26, 2017 •

edited

jasmussen commented Jun 26, 2017

ellatrix commented Jun 26, 2017

jasmussen commented Jun 26, 2017

ellatrix commented Jun 26, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

ellatrix commented Jul 3, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

jasmussen commented Jul 3, 2017

ellatrix commented Jul 3, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

BoardJames commented Jul 4, 2017

ellatrix commented Jul 7, 2017

jasmussen left a comment

ellatrix commented Jul 14, 2017

aduth Jul 14, 2017

ellatrix Jul 18, 2017

aduth Jul 14, 2017

aduth Jul 14, 2017

ellatrix Jul 18, 2017

Use the "old" editor as the freeform block #1394

Use the "old" editor as the freeform block #1394

Conversation

ellatrix commented Jun 23, 2017 • edited

ellatrix commented Jun 23, 2017

jasmussen commented Jun 23, 2017

ellatrix commented Jun 23, 2017 • edited

BoardJames left a comment

Choose a reason for hiding this comment

BoardJames Jun 26, 2017

Choose a reason for hiding this comment

BoardJames commented Jun 26, 2017 • edited

jasmussen commented Jun 26, 2017

ellatrix commented Jun 26, 2017

jasmussen commented Jun 26, 2017

ellatrix commented Jun 26, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

ellatrix commented Jul 3, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

jasmussen commented Jul 3, 2017

ellatrix commented Jul 3, 2017

ellatrix commented Jul 3, 2017

jasmussen commented Jul 3, 2017

BoardJames commented Jul 4, 2017

ellatrix commented Jul 7, 2017

jasmussen left a comment

Choose a reason for hiding this comment

ellatrix commented Jul 14, 2017

aduth Jul 14, 2017

Choose a reason for hiding this comment

ellatrix Jul 18, 2017

Choose a reason for hiding this comment

aduth Jul 14, 2017

Choose a reason for hiding this comment

aduth Jul 14, 2017

Choose a reason for hiding this comment

ellatrix Jul 18, 2017

Choose a reason for hiding this comment

ellatrix commented Jun 23, 2017 •

edited

ellatrix commented Jun 23, 2017 •

edited

BoardJames commented Jun 26, 2017 •

edited