Backport fixes to WordPress 5.5 beta2 #23903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a console error (#23666)
…sted block list, but root appender is used. (#23668) * Remove use of getSelectionEnd to determine where blocks should be inserted * Add e2e tests
Image edit: Fix cases where the edited Image src doesn't match the attachment ID. Includes backwards compatibility for WordPress 5.4 or lower.
* Search: Fix attribute defaults Prior to d26842b, the Search block's label and buttonText attributes defaulted to `__( 'Search' )`. This meant that adding a Search block to a post or page resulted in `<!-- wp:search /-->` being inserted into the HTML. In d26842b, the defaults were removed so that Search could use a block.json file. The default values were instead implemented using a default block variation. This, however, meant that Search blocks added prior to d26842b would render with a blank label and button. This fix is to default label and buttonText to `__( 'Search' )` in the render_callback. Care must be taken here to permit these attributes to be '' in which case the label and/or button are hidden. * Try to trick GitHub into re-running tests
Co-authored-by: Zebulan Stanphill <zebulanstanphill@protonmail.com>
Co-authored-by: Riad Benguella <benguella@gmail.com>
youknowriad
requested review from
ajitbohra,
ajlende,
chrisvanpatten,
ellatrix,
gziolo,
nerrad,
ntwb,
Soean,
spacedmonkey,
talldan and
TimothyBJacobs
as code owners
|
Size Change: +267 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
What's the process for this? Do you remove the label afterwards? Anything more we should include? |
|
@ellatrix yes, that's the process, I explicitly left the patterns ones out for this beta. These require their own backport in Core, but better done once they are all ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the fixes included in this PR: