Fix tiny editor preview when using Mobile or Tablet options with metaboxes enabled #24478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
commented
Aug 11, 2020
Comment on lines
+62
to
+64
| height, | ||
| minHeight: height, | ||
| maxHeight: height, |
There was a problem hiding this comment.
Seems unusual that three height properties are needed, but I couldn't see another way.
|
Size Change: +7 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Aug 12, 2020
talldan
added
the
Backport to WP Beta/RC
This was referenced Aug 18, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Aug 26, 2020
tellthemachines
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23404.
The issue was caused by
overflow-y: autobeing applied to the editor area, but nomin-heightbeing set which caused the area to collapse.I've fixed this by making the preview area generally try to have the right dimensions for the desired devices (min-height of 768px for the mobile option, and 1024px for the Tablet option).
This does result in the metabox options being pushed down the page a bit, but I think this is ok, the user can still scroll down, and generally has to do that anyway outside of preview. When a user selects one of those preview options, they generally want to be able to see the content at the right size first and foremost.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: