Fix specificity for buttons with outline style and background colors #24599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the .wp-block-button.is-style-outline .wp-block-button_link selector was added, its specificity (030) overrode existing theme selectors that had 020 specificity.
oandregal
added
[Block] Buttons
|
Size Change: +165 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP Beta/RC
youknowriad
reviewed
Aug 17, 2020
oandregal
commented
Aug 18, 2020
youknowriad
reviewed
Aug 18, 2020
This reverts commit a730cf3.
youknowriad
approved these changes
Aug 18, 2020
oandregal
added
the
[Feature] Themes
jorgefilipecosta
pushed a commit
that referenced
this pull request
Aug 26, 2020
…24599) When the .wp-block-button.is-style-outline .wp-block-button_link selector was added, its specificity (030) overrode existing theme selectors that had 020 specificity.
|
While testing this I ran into some odd behaviour,
|
ZebulanStanphill
added a commit
that referenced
this pull request
Aug 30, 2020
Follow up to #24599. Using the child combinator (instead of the descendant combinator) narrows the selector without increasing its specificity. This should help reduce the likelihood of a style issue occurring when a parent element has an `is-style-outline` CSS class. https://developer.mozilla.org/en-US/docs/Web/CSS/Child_combinator
|
hi @sannevndrmeulen this fix hasn't yet made available. It will be in Gutenberg 8.9 (to be released this week) and WordPress 5.5.1 (to be released soon). So, unless you've compiled and tested specifically this PR, what you experienced is the current buggy behavior. |
|
Hi, Please don't forget about #24625 too. Thanks! |
mkaz
pushed a commit
that referenced
this pull request
Oct 19, 2020
Follow up to #24599. Using the child combinator (instead of the descendant combinator) narrows the selector without increasing its specificity. This should help reduce the likelihood of a style issue occurring when a parent element has an `is-style-outline` CSS class. https://developer.mozilla.org/en-US/docs/Web/CSS/Child_combinator
tellthemachines
removed
the
Backport to WP Beta/RC
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/WordPress/gutenberg/pull/21816/files#r471447642
Related: forum thread
This fixes a regression for the button block when the outline style is applied: unlike WordPress 5.4, the background color wasn't applied in this scenario.
Test
The expected result is that the button has the background color selected, both in the editor and in the front. Tested with the themes TwentyTwenty, TwentyNineteen, TwentySeventeen. This was the behavior in 5.4 that we regressed in 5.5.