Submenus shouldn't take space unless they're actually open. #31881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +95 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
gwwar
reviewed
May 18, 2021
There was a problem hiding this comment.
I think the proposed changes make sense, but I wanted to check in on PageList behavior and whether or not clicks/hovers should display submenus.
Here's trunk behavior with Navigation block populated with PageList:
trunk.mp4
Here's the branch behavior with Navigation block populated with PageList:
submenu.mp4
|
Excellent catch, Kerry. Thanks so much, that was not an intended regression, but an oversight which I've fixed:
|
jasmussen
force-pushed
the
try/invisible-submenus
branch
from
7eb8e41
to
3222727
Compare
Mamaduka
approved these changes
May 20, 2021
jasmussen
force-pushed
the
try/invisible-submenus
branch
from
3222727
to
19b233a
Compare
jasmussen
force-pushed
the
try/invisible-submenus
branch
from
19b233a
to
1ed3b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently submenus in the navigation block are
visibility: hidden;until you tab or click into them. That, however, means they still take up space in the viewport, as opposed todisplay: none;, which actually makes it disappear.This particular behavior meant you could have a horizontal scrollbar appear for no reason:
This PR fixes that:
On smaller viewports, nested submenus don't open rightwards, they open downwards and "stack". The alignment was off, though:
That's fixed too:
When menus have color, those rules are different, so that's tweaked too:
How has this been tested?
Please insert a navigation menu that has a bunch of nested submenu items.
Then test it with and without background colors, on small and medium (600px plus) viewport breakpoints.
Menus should look good, and there shouldn't be a horizontal scrollbar when submenu items aren't open.
Checklist:
*.native.jsfiles for terms that need renaming or removal).