@@ -1,3 +1,5 @@ +require 'shellwords' + require 'rubygems/command' require 'rubygems/dependency' require 'rubygems/version_option' @@ -60,7 +62,9 @@ class Gem::Commands::OpenCommand < Gem::Command if !editor say "Either set $EDITOR, or use -c <command_name>" else - success = system(editor, path) + command_parts = Shellwords.shellwords(editor) + command_parts << path + success = system(*command_parts) if !success raise Gem::CommandLineError, "Could not run '#{editor} #{path}', exit code: #{$?.exitstatus}" end lib/rubygems/commands/open_command.rb @@ -38,5 +38,4 @@ class Test_SomethingToTest < Test::Unit::TestCase command.invoke() end end - end \ No newline at end of file test/open_command_test.rb bf2b15d4af4fc8f4fc29d7a81ec20e17a11358e0 Adam Sanderson netghost@gmail.com http://github.com/adamsanderson/open_gem/commit/ee15a7eb61d254c4c9d92a2afc74e36ea3ad3880 ee15a7eb61d254c4c9d92a2afc74e36ea3ad3880 2009-05-02T09:29:37-07:00 2009-05-02T09:29:37-07:00 properly handles commands with arguments. 2d2e04694b0d5a509599eaf067562791cc64ae36 Adam Sanderson netghost@gmail.com